danielcweeks commented on code in PR #5268: URL: https://github.com/apache/iceberg/pull/5268#discussion_r920221226
########## api/src/main/java/org/apache/iceberg/metrics/ScanMetricsContext.java: ########## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.metrics; + +import java.util.StringJoiner; + +public class ScanMetricsContext implements MetricsContext { Review Comment: The original idea behind the MetricsContext interface was to provide a way to delegate to different implementations for creating telemetry primitives (like Counter, Timer, Guage, etc.). You can imagine implementations like: `HadoopMetricsContext` (this exists, but is a wierd implementation because of how it interacts with FileSystem) `DefaultMetricsContext` (provides native counters/timers like you've created) `MicroMeterMetricsContext` (delegates the creation to a micrometer implementation) I think this implementation is sort of straddling the ScanReport and the MetricsContext. You might consider just having: ```java class ScanReport { TableIdentifier identifier; Schmea schema; ... class Metrics { Counter matchingDataFilesCount = metricsContext.counter("matchingDataFilesCount", Integer.class, Unit.COUNT); Counter totalDatamanifestsReadCoun = metricsContext.counter("totalDatamanifestsReadCoun", Integer.class, Unit.COUNT)t; ... Timer totalScanDuration metricsContext.timer("totalScanDuration", Unit.MILLISECOND); } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
