shidayang commented on code in PR #5264:
URL: https://github.com/apache/iceberg/pull/5264#discussion_r920648848
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -226,8 +226,10 @@ private CloseableIterable<T>
applyPosDeletes(CloseableIterable<T> records) {
// if there are fewer deletes than a reasonable number to keep in memory,
use a set
if (posDeletes.stream().mapToLong(DeleteFile::recordCount).sum() <
setFilterThreshold) {
Review Comment:
But, They should't reopen position delete file and read position delete file
from head, they should read position delete file continue。I will do some change
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
