Mehul2500 commented on code in PR #5037:
URL: https://github.com/apache/iceberg/pull/5037#discussion_r921579263
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java:
##########
@@ -356,6 +360,81 @@ public void testListTables() {
Assertions.assertThat(catalog.tableExists(TABLE_IDENTIFIER)).isTrue();
}
+ private void testRegister(TableIdentifier identifier, String
metadataVersionFiles) {
Review Comment:
A good suggestion of using `CatalogTests`, but the duplicated test code
referred to under these comments above shall not be resolved using
`CatalogTests`.
Reason:
1. The duplicated test code is with two of the test cases, i.e.,
testRegisterTable() and testRegisterExistingTable() in three of the catalog
test files.
- Jdbc Catalog
- Ecs Catalog
- Hadoop Catalog
Out of these only Jdbc catalog is one which can use `CatalogTests`, others
do not use `CatalogTests`.
Thus, it won't be helpful to consider `CatalogTests` under this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
