rdblue commented on issue #4168: URL: https://github.com/apache/iceberg/issues/4168#issuecomment-1185766609
Looks like one problem is that the exception is [logged but not rethrown in the async future](https://github.com/apache/iceberg/blob/master/aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java#L309-L318). Because no exception is thrown, the call to `CompleteableFuture::join` in `completeMultipartUpload` succeeds and should return `null` for that part. I would expect `completeMultipartUpload` to also fail because it tries to sort the parts (with at least one null part) by `CompletedPart::partNumber`. So there should be another failure somewhere. This may be slightly incorrect since it looks like the thread pool executor is actually handling the exception (which is why the trace goes up to `ThreadPoolExecutor`. Either way, it looks like some exception should cause close to fail, but that is apparently ignored since the writer creates metadata for the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
