RussellSpitzer commented on code in PR #4325:
URL: https://github.com/apache/iceberg/pull/4325#discussion_r922405373


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -271,12 +271,12 @@ public static List<SparkPartition> 
getPartitionsByFilter(SparkSession spark, Tab
    * @param metricsConfig a metrics conf
    * @return a List of DataFile
    * @deprecated use {@link TableMigrationUtil#listPartition(Map, String, 
String, PartitionSpec, Configuration,
-   * MetricsConfig, NameMapping)}
+   * MetricsConfig, NameMapping, boolean)}
    */
   @Deprecated
   public static List<DataFile> listPartition(SparkPartition partition, 
PartitionSpec spec,
                                              SerializableConfiguration conf, 
MetricsConfig metricsConfig) {
-    return listPartition(partition, spec, conf, metricsConfig, null);
+    return listPartition(partition, spec, conf, metricsConfig, null, false);

Review Comment:
   we can't change deprecated methods



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to