amogh-jahagirdar commented on code in PR #5046:
URL: https://github.com/apache/iceberg/pull/5046#discussion_r922590682
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -140,17 +155,22 @@ public void initialize(Map<String, String> properties) {
AwsProperties.S3_USE_ARN_REGION_ENABLED,
AwsProperties.S3_USE_ARN_REGION_ENABLED_DEFAULT
);
-
ValidationException.check(
(s3AccessKeyId == null) == (s3SecretAccessKey == null),
- "S3 client access key ID and secret access key must be set at the
same time");
+ "S3 client access key ID and secret access key must be set at the
same time"
+ );
+
+ this.kmsRegion = properties.get(AwsProperties.KMS_REGION);
+ this.glueRegion = properties.get(AwsProperties.GLUE_REGION);
+ this.dynamoDbRegion = properties.get(AwsProperties.DYNAMODB_REGION);
this.dynamoDbEndpoint = properties.get(AwsProperties.DYNAMODB_ENDPOINT);
+
Review Comment:
Nit: unnecessary new line
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -539,6 +563,7 @@ public void setGlueCatalogId(String id) {
public boolean glueCatalogSkipArchive() {
return glueCatalogSkipArchive;
}
+
Review Comment:
Nit: Unnecessary new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
