hililiwei commented on code in PR #4325:
URL: https://github.com/apache/iceberg/pull/4325#discussion_r922661319
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -375,12 +376,67 @@ private static Iterator<ManifestFile>
buildManifest(SerializableConfiguration co
* @param sourceTableIdent an identifier of the source Spark table
* @param targetTable an Iceberg table where to import the data
* @param stagingDir a staging directory to store temporary manifest files
- * @param partitionFilter only import partitions whose values match those in
the map, can be partially defined
+ */
+ public static ImportSparkTableBuilder importSparkTableBuilder(SparkSession
spark, TableIdentifier sourceTableIdent,
+ Table
targetTable, String stagingDir) {
+ return new ImportSparkTableBuilder(spark, sourceTableIdent, targetTable,
stagingDir);
+ }
+
+ public static class ImportSparkTableBuilder {
Review Comment:
Also, I had to create multiple methods to distinguish checkDuplicateFiles
from skipOnError. It can not specify parameter name when values are passed in,
as Scala does. 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
