Fokko commented on code in PR #5287:
URL: https://github.com/apache/iceberg/pull/5287#discussion_r922890885
##########
python/pyiceberg/table/metadata.py:
##########
@@ -347,10 +345,10 @@ class TableMetadata:
@staticmethod
def parse_obj(data: dict) -> Union[TableMetadataV1, TableMetadataV2]:
- if "format-version" not in data:
+ if "format-version" not in data and "format_version" not in data:
Review Comment:
Yea, this is supspicious. I'm going to remove all the `pre_validators`
because you can enter there the normal field name (`format_version`) and the
alias (`format-version`) which makes it very confusing, clutters up the code,
and makes it harder to comprehend the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
