nastra commented on code in PR #5268:
URL: https://github.com/apache/iceberg/pull/5268#discussion_r923443028
##########
core/src/main/java/org/apache/iceberg/ManifestGroup.java:
##########
@@ -234,7 +255,13 @@ private <T> Iterable<CloseableIterable<T>> entries(
manifest -> manifest.hasAddedFiles() || manifest.hasDeletedFiles());
}
- matchingManifests = Iterables.filter(matchingManifests,
manifestPredicate::test);
+ matchingManifests = Iterables.filter(matchingManifests, manifest -> {
Review Comment:
that would obviously also work and I'm completely open to suggestions. The
only downside of this approach is that we're creating a new iterator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
