nastra commented on code in PR #5291:
URL: https://github.com/apache/iceberg/pull/5291#discussion_r924503978
##########
core/src/main/java/org/apache/iceberg/SchemaParser.java:
##########
@@ -254,8 +254,8 @@ private static Types.MapType mapFromJson(JsonNode json) {
}
public static Schema fromJson(JsonNode json) {
- Type type = typeFromJson(json);
- Preconditions.checkArgument(type.isNestedType() &&
type.asNestedType().isStructType(),
+ Type type = typeFromJson(json);
+ Preconditions.checkArgument(type != null && type.isNestedType() &&
type.asNestedType().isStructType(),
Review Comment:
interesting, I wonder if this is something that we're expecting to happen.
From the code around `typeFromJson(..)` it looks like there shouldn't be a
`null` returned. It's probably worth adding a test for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
