karuppayya commented on code in PR #4652:
URL: https://github.com/apache/iceberg/pull/4652#discussion_r925010721


##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -80,6 +81,41 @@ public interface DeleteOrphanFiles extends 
Action<DeleteOrphanFiles, DeleteOrpha
    */
   DeleteOrphanFiles executeDeleteWith(ExecutorService executorService);
 
+  /**

Review Comment:
   done



##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -80,6 +81,41 @@ public interface DeleteOrphanFiles extends 
Action<DeleteOrphanFiles, DeleteOrpha
    */
   DeleteOrphanFiles executeDeleteWith(ExecutorService executorService);
 
+  /**
+   * Pass a mode for handling the files that cannot be determined if they are 
orphan
+   * The allowed modes are "IGNORE", "ERROR", "DELETE"
+   * Default prefixMismatchMode is "ERROR".
+   *
+   * @param mode mode for handling files that cannot be determined if they are 
orphan
+   * @return this for method chaining
+   */
+  default DeleteOrphanFiles prefixMismatchMode(PrefixMismatchMode mode) {
+    throw new UnsupportedOperationException(this.getClass().getName() + " does 
not implement prefixMismatchMode");
+  }
+
+  /**

Review Comment:
   done



##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -80,6 +81,41 @@ public interface DeleteOrphanFiles extends 
Action<DeleteOrphanFiles, DeleteOrpha
    */
   DeleteOrphanFiles executeDeleteWith(ExecutorService executorService);
 
+  /**
+   * Pass a mode for handling the files that cannot be determined if they are 
orphan
+   * The allowed modes are "IGNORE", "ERROR", "DELETE"
+   * Default prefixMismatchMode is "ERROR".
+   *
+   * @param mode mode for handling files that cannot be determined if they are 
orphan
+   * @return this for method chaining
+   */
+  default DeleteOrphanFiles prefixMismatchMode(PrefixMismatchMode mode) {
+    throw new UnsupportedOperationException(this.getClass().getName() + " does 
not implement prefixMismatchMode");
+  }
+
+  /**
+   * Pass a Map with a String key and comma separated list of schemes  to be 
considered equal when finding orphan files.
+   * example: Map("s3", "s3a, s3, s3n")
+   *
+   * @param equalSchemes list of equal schemes
+   * @return this for method chaining
+   */
+  default DeleteOrphanFiles equalSchemes(Map<String, String> equalSchemes) {
+    throw new UnsupportedOperationException(this.getClass().getName() + " does 
not implement equalSchemes");
+  }
+
+  /**

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to