stevenzwu commented on code in PR #5318:
URL: https://github.com/apache/iceberg/pull/5318#discussion_r926177222
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScanSql.java:
##########
@@ -84,171 +65,7 @@ private TableEnvironment getTableEnv() {
protected List<Row> run(FlinkSource.Builder formatBuilder, Map<String,
String> sqlOptions, String sqlFilter,
String... sqlSelectedFields) {
String select = String.join(",", sqlSelectedFields);
-
- StringBuilder builder = new StringBuilder();
- sqlOptions.forEach((key, value) -> builder.append(optionToKv(key,
value)).append(","));
-
- String optionStr = builder.toString();
-
- if (optionStr.endsWith(",")) {
- optionStr = optionStr.substring(0, optionStr.length() - 1);
- }
-
- if (!optionStr.isEmpty()) {
- optionStr = String.format("/*+ OPTIONS(%s)*/", optionStr);
- }
-
- return sql("select %s from t %s %s", select, optionStr, sqlFilter);
- }
-
- @Test
- public void testResiduals() throws Exception {
Review Comment:
remaining test methods are refactored into `TestSqlBase` to share the test
btw current and new FLIP-27 sources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
