jfz commented on PR #5282: URL: https://github.com/apache/iceberg/pull/5282#issuecomment-1191677388
> @jfz can you refactor the manual testing in the description to proper unit tests? @stevenzwu Thanks for looking into this. The challenge to test retry is that it requires "S3Mock" code change and still tricky to get only a particular request to fail at first attempt and succeed later. The happen path (upload a s3 object with size over 128k) is well covered in existing tests though, the above example is actually simplified from an existing test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
