kbendick commented on code in PR #5305: URL: https://github.com/apache/iceberg/pull/5305#discussion_r927179174
########## spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkTruncateFunction.java: ########## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark.sql; + +import java.io.UnsupportedEncodingException; +import java.math.BigDecimal; +import java.nio.charset.StandardCharsets; +import java.util.Map; +import org.apache.iceberg.AssertHelpers; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.relocated.com.google.common.io.BaseEncoding; +import org.apache.iceberg.spark.SparkCatalogTestBase; +import org.apache.spark.sql.AnalysisException; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +public class TestSparkTruncateFunction extends SparkCatalogTestBase { + private static final Namespace NS = Namespace.of("db"); + + private final String fullNamespace; + + public TestSparkTruncateFunction(String catalogName, String implementation, Map<String, String> config) { + super(catalogName, implementation, config); + this.fullNamespace = ("spark_catalog".equals(catalogName) ? "" : catalogName + ".") + NS; + } + + @Before + public void createNamespace() { + sql("CREATE NAMESPACE IF NOT EXISTS %s", fullNamespace); + sql("USE %s", fullNamespace); Review Comment: Removed the namespace from here as it's not needed. As mentioned here https://github.com/apache/iceberg/pull/5305#discussion_r927178316, we will hold off on `SparkSessionCatalog` and then follow up with handling the need for `system` namespace in spark session catalog in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
