nastra commented on code in PR #5337:
URL: https://github.com/apache/iceberg/pull/5337#discussion_r927873493
##########
flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##########
@@ -396,7 +396,7 @@ public void
testIncrementalFromSnapshotTimestampWithEmptyTable() throws Exceptio
AssertHelpers.assertThrows("Should detect invalid starting snapshot
timestamp",
IllegalArgumentException.class,
- "Cannot find a snapshot older than 1970-01-01 00:00:00.001",
+ "Cannot find a snapshot older than 1970-01-01T00:00:00.001+00:00",
Review Comment:
It feels more natural to adhere to the ISO standard as that is pretty well
understood. Also people could really just copy/paste this (not sure if anyone
would actually do that) and parse it. I don't see any clear benefit to not
adhere to the ISO standard, but happy to change if others think we should use
something non-standard here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
