rdblue commented on code in PR #4945:
URL: https://github.com/apache/iceberg/pull/4945#discussion_r928161714


##########
format/spec.md:
##########
@@ -632,6 +632,29 @@ When expiring snapshots, retention policies in table and 
snapshot references are
     2. The snapshot is not one of the first `min-snapshots-to-keep` in the 
branch (including the branch's referenced snapshot)
 5. Expire any snapshot not in the set of snapshots to retain.
 
+#### Snapshot statistics
+
+Snapshot statistics files are valid [Puffin files](../puffin-spec). Statistics 
are informational. A reader can choose to
+ignore statistics information. Statistics support is not required to read the 
table correctly.
+
+Statistics files metadata within `snapshot-statistics` table metadata field is 
a struct with the following fields:
+
+| v1         | v2         | Field name                      | Type             
                 | Description                                                  
                                                                             |
+|------------|------------|---------------------------------|-----------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------|
+| _required_ | _required_ | **`snapshot-id`**               | `string`         
                 | ID of the Iceberg table's snapshot the blob was computed 
from.                                                                           
 |

Review Comment:
   This refers to "the blob", but I think it should be for the stats file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to