deadwind4 commented on code in PR #5334: URL: https://github.com/apache/iceberg/pull/5334#discussion_r928453975
########## docs/configuration.md: ########## @@ -79,6 +79,7 @@ Iceberg tables support table properties to configure table behavior, like the de | write.object-storage.enabled | false | Enables the object storage location provider that adds a hash component to file paths | | write.data.path | table location + /data | Base location for data files | | write.metadata.path | table location + /metadata | Base location for metadata files | +| write.upsert.enabled | false | Enables upsert mode (currently flink only) | Review Comment: https://github.com/apache/iceberg/blob/5951ece2cedf82c69ae717a20c6b392b0b76237c/docs/flink-getting-started.md?plain=1#L570 The `upsert-enabled` option in the Flink section is not general table property, but the `write.upsert.enabled` option is general table property. Maybe, in the future, we will implement `write.upsert.enabled` in Spark. The `upsert-enabled` option has been in the doc, but there is no `write.upsert.enabled` in the doc. I have a fear that some users get confusing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
