stevenzwu opened a new pull request, #5353:
URL: https://github.com/apache/iceberg/pull/5353
…ld env dependent. It will fail with ImmutableMap.of("user-test",
System.getenv().get("USER")), if the build env doesn't contain USER env
variable, which is the case for our internal build env.
java.lang.NullPointerException: null value in entry: user-test=null
at
org.apache.iceberg.relocated.com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPreconditions.java:33)
at
org.apache.iceberg.relocated.com.google.common.collect.SingletonImmutableBiMap.<init>(SingletonImmutableBiMap.java:43)
at
org.apache.iceberg.relocated.com.google.common.collect.ImmutableBiMap.of(ImmutableBiMap.java:81)
at
org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap.of(ImmutableMap.java:126)
at
org.apache.iceberg.util.TestEnvironmentUtil.testEnvironmentSubstitution(TestEnvironmentUtil.java:31)
Also this test only covers a trivial method
public static Map<String, String> resolveAll(Map<String, String>
properties) {
return resolveAll(System.getenv(), properties);
}
the other non-public resolveAll is already covered by
TestEnvironmentUtil#testMultipleEnvironmentSubstitutions().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
