danielcweeks commented on code in PR #5345:
URL: https://github.com/apache/iceberg/pull/5345#discussion_r930360699
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -143,6 +143,10 @@ private TableProperties() {
public static final String DELETE_PARQUET_PAGE_SIZE_BYTES =
"write.delete.parquet.page-size-bytes";
public static final int PARQUET_PAGE_SIZE_BYTES_DEFAULT = 1024 * 1024; // 1
MB
+ public static final String PARQUET_PAGE_ROW_LIMIT =
"write.parquet.page-row-limit";
+ public static final String DELETE_PARQUET_PAGE_ROW_LIMIT =
"write.delete.parquet.page-row-limit";
Review Comment:
I think `page-row-limit` is clear enough. There is also a page size limit,
but I feel the count is implied given it's rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
