rdblue commented on code in PR #5362:
URL: https://github.com/apache/iceberg/pull/5362#discussion_r930468732
##########
python/pyiceberg/expressions/base.py:
##########
@@ -204,6 +210,7 @@ def __eq__(self, other) -> bool:
)
+# TODO: this should still exist as a parent, but term should be abstract
Review Comment:
The `UnaryPredicate` and `BoundUnaryPredicate` classes introduced in this PR
should implement the `UnboundPredicate` and `BoundPredicate` interfaces, but I
didn't want to refactor the entire set of expressions in this PR so I added
this TODO as a reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
