rdblue commented on code in PR #5361:
URL: https://github.com/apache/iceberg/pull/5361#discussion_r931545466
##########
settings.gradle:
##########
@@ -52,37 +52,41 @@ project(':nessie').name = 'iceberg-nessie'
project(':gcp').name = 'iceberg-gcp'
project(':dell').name = 'iceberg-dell'
+List<String> knownScalaVersions =
System.getProperty("knownScalaVersions").split(",")
+String scalaVersion = System.getProperty("scalaVersion",
System.getProperty("defaultScalaVersion"))
+if (!knownScalaVersions.contains(scalaVersion)) {
+ throw new GradleException("Found unsupported Scala version: " + scalaVersion)
Review Comment:
Rather than throwing an exception, I think this should just exclude the
projects from the build. Here's an example:
https://github.com/apache/iceberg/blob/master/settings.gradle#L175-L193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
