SinghAsDev commented on code in PR #5036:
URL: https://github.com/apache/iceberg/pull/5036#discussion_r931681910
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -632,4 +666,43 @@ private static boolean hiveEngineEnabled(TableMetadata
metadata, Configuration c
return conf.getBoolean(ConfigProperties.ENGINE_HIVE_ENABLED,
TableProperties.ENGINE_HIVE_ENABLED_DEFAULT);
}
+
+ private static class HiveLockHeartbeat implements Runnable {
+ private final ClientPool<IMetaStoreClient, TException> hmsClients;
+ private final long lockId;
+ private final long intervalMs;
+ private ScheduledFuture<?> future;
+ private volatile Exception encounteredException = null;
+
+ HiveLockHeartbeat(ClientPool<IMetaStoreClient, TException> hmsClients,
long lockId, long intervalMs) {
+ this.hmsClients = hmsClients;
+ this.lockId = lockId;
+ this.intervalMs = intervalMs;
+ this.future = null;
+ }
+
+ @Override
+ public void run() {
+ try {
+ hmsClients.run(client -> {
+ client.heartbeat(0, lockId);
+ return null;
+ });
+ } catch (TException | InterruptedException e) {
+ this.encounteredException = e;
+ throw new CommitFailedException(e, "Failed to heartbeat for lock: %d",
lockId);
Review Comment:
It is not, but throwing exception here will stop the future runs of this
runnable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
