samredai commented on code in PR #5332:
URL: https://github.com/apache/iceberg/pull/5332#discussion_r931753841
##########
python/Makefile:
##########
@@ -17,13 +17,22 @@
install:
pip install poetry
- poetry install -E pyarrow
+ poetry install -E pyarrow -E s3fs
lint:
poetry run pre-commit run --all-files
-
test:
+ poetry run coverage run --source=pyiceberg/ -m pytest tests/ -m "not
s3" ${PYTEST_ARGS}
+ poetry run coverage report -m --fail-under=90
+ poetry run coverage html
+ poetry run coverage xml
+test-all:
poetry run coverage run --source=pyiceberg/ -m pytest tests/
${PYTEST_ARGS}
poetry run coverage report -m --fail-under=90
poetry run coverage html
poetry run coverage xml
+test-s3:
Review Comment:
That's a great idea, we already use `PYTEST_ARGS` and I think we could just
pass in the marked tests we want to run using that 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
