nastra commented on code in PR #5386:
URL: https://github.com/apache/iceberg/pull/5386#discussion_r932973215
##########
api/src/main/java/org/apache/iceberg/metrics/MetricsContext.java:
##########
@@ -77,9 +77,23 @@ default T value() {
throw new UnsupportedOperationException("Count is not supported.");
}
+ /**
+ * The unit of the counter.
+ *
+ * @return The unit of the counter.
+ */
default Unit unit() {
return Unit.UNDEFINED;
Review Comment:
I wasn't sure if we'd want to change the default here to `Unit.COUNT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
