rdblue commented on code in PR #5338:
URL: https://github.com/apache/iceberg/pull/5338#discussion_r933876206


##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -41,11 +41,11 @@ public interface ManifestFile {
       "Lowest sequence number in the manifest");
   Types.NestedField SNAPSHOT_ID = optional(503, "added_snapshot_id", 
Types.LongType.get(),
       "Snapshot ID that added the manifest");
-  Types.NestedField ADDED_FILES_COUNT = optional(504, 
"added_data_files_count", Types.IntegerType.get(),

Review Comment:
   > Ugh, is this now used to track the number of added delete files in our 
delete manifests too?
   
   Yeah, we decided to use the existing metadata fields for the same purpose in 
delete manifests. I think it makes sense -- is there a problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to