amogh-jahagirdar commented on PR #4401: URL: https://github.com/apache/iceberg/pull/4401#issuecomment-1200342190
Discussed offline with @jackye1995 I'll be carrying this PR forward. So my thinking is the following: 1.) I do think we need to have an explicit flag for ignoring deletes, it makes sense to me that the operation fails if there are deletes. This is because as a user I expect the actual state of the table to be represented in the symlink file by default. If the operation fails, it does force a user to do a compaction prior to running this procedure but I think that still makes sense. And then if they really don't want this behavior they can pass in the flag to ignore deletes @kbendick @jackye1995 let me know your thinking or we can discuss on the PRs I plan on raising. 2.) Looks like there's interest in having this be an actual Spark Action, I will add that. @jackye1995 Feel free to close this, I will add you as a co-author on the PRs I raise. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
