rdblue commented on code in PR #5391: URL: https://github.com/apache/iceberg/pull/5391#discussion_r934030613
########## python/vendor/hive_metastore/ThriftHiveMetastore-remote: ########## @@ -0,0 +1,3364 @@ +#!/usr/bin/env python +# +# Autogenerated by Thrift Compiler (0.16.0) +# +# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING +# +# options string: py +# + +import pprint +import sys + +if sys.version_info[0] > 2: + from urllib.parse import urlparse +else: + from urlparse import urlparse + +from hive_metastore import ThriftHiveMetastore +from hive_metastore.ttypes import * +from thrift.protocol.TBinaryProtocol import TBinaryProtocol +from thrift.transport import ( + THttpClient, + TSocket, + TSSLSocket, + TTransport, +) + +if len(sys.argv) <= 1 or sys.argv[1] == "--help": Review Comment: I think we should remove it if it isn't needed. It's just unnecessary code to deal with. We only need to exclude it the first time. The next time we generate this only the files that were already added will be changed on commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
