rdblue commented on code in PR #5391:
URL: https://github.com/apache/iceberg/pull/5391#discussion_r934992661
##########
python/pyiceberg/catalog/base.py:
##########
@@ -161,12 +161,12 @@ def drop_namespace(self, namespace: str | Identifier) ->
None:
namespace: Namespace identifier
Raises:
- NamespaceNotFoundError: If a namespace with the given name does
not exist
+ NoSuchNamespaceError: If a namespace with the given name does not
exist
NamespaceNotEmptyError: If the namespace is not empty
"""
@abstractmethod
- def list_tables(self, namespace: str | Identifier | None = None) ->
list[Identifier]:
+ def list_tables(self, namespace: str | Identifier) -> list[Identifier]:
Review Comment:
I think that having `None` here was correct. You can list tables in the root
namespace.
##########
python/pyiceberg/catalog/base.py:
##########
@@ -138,7 +138,7 @@ def rename_table(self, from_identifier: str | Identifier,
to_identifier: str | I
Table: the updated table instance with its metadata
Raises:
- TableNotFoundError: If a table with the name does not exist
+ NoSuchTableError: If a table with the name does not exist
Review Comment:
Can you open a separate PR for these refactoring changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
