dramaticlly commented on code in PR #5412:
URL: https://github.com/apache/iceberg/pull/5412#discussion_r935006214
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java:
##########
@@ -139,6 +152,14 @@ public ExpireSnapshotsSparkAction
deleteWith(Consumer<String> newDeleteFunc) {
return this;
}
+ public ExpireSnapshotsSparkAction bulkDeleteWith(Consumer<Iterable<String>>
newBulkDeleteFunc) {
+ Preconditions.checkArgument(
+ ops.io() instanceof SupportsBulkOperations,
+ "FileIO %s does not support bulk deletion",
+ table.io().getClass().getName());
Review Comment:
I shall probably move this `table.io()` to `ops.io()` for consistency, but
given check take 1+hr to complete, I will handle it together with other review
feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
