stevenzwu commented on code in PR #5311:
URL: https://github.com/apache/iceberg/pull/5311#discussion_r935111103
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java:
##########
@@ -257,6 +258,13 @@ private void newStream() throws IOException {
@Override
public void close() throws IOException {
+
+ // A failed s3 close removes state that is required for a successful close.
Review Comment:
nit: wondering if the following comment is a little more clear based on
Russel's comment
```
A previously failed close left the S3 output stream in a bad state that is
non-recoverable.
Any future close on this stream should fail.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
