rdblue commented on code in PR #4826:
URL: https://github.com/apache/iceberg/pull/4826#discussion_r937079863
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java:
##########
@@ -561,28 +561,26 @@ protected String getTableLocation(String tableName) {
return getTableLocationPath(tableName).toString();
}
- private String metadataLocation(String tableName) {
- return Paths.get(getTableBasePath(tableName), "metadata").toString();
- }
-
@SuppressWarnings(
"RegexpSinglelineJava") // respecting this rule requires a lot more
lines of code
- private List<String> metadataFiles(String tableName) {
- return Arrays.stream(Objects.requireNonNull(new
File(metadataLocation(tableName)).listFiles()))
+ private List<String> metadataFiles(String tablePath) {
+ return Arrays.stream(
+ Objects.requireNonNull(new File((tablePath + "/" +
"metadata")).listFiles()))
Review Comment:
I'd rather not mix file system APIs. This uses both Path and File. Can you
get rid of `Path` and make that a string everywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
