rdblue commented on PR #5436: URL: https://github.com/apache/iceberg/pull/5436#issuecomment-1205547639
I don't think that we should add `__enter__` and `__exit__` to `InputFile` or `OutputFile` because of the inability to use them as factories as intended. Can we get around the implementations not supporting `__enter__` and `__exit__` by adding them using `object.__setattr__` when we create them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
