kbendick commented on code in PR #5438:
URL: https://github.com/apache/iceberg/pull/5438#discussion_r938075088
##########
core/src/main/java/org/apache/iceberg/util/JsonUtil.java:
##########
@@ -98,6 +98,11 @@ public static <T> T parse(String json, FromJson<T> parser) {
}
}
+ public static JsonNode get(String property, JsonNode node) {
+ Preconditions.checkArgument(node.has(property), "Cannot parse missing
object '%s'", property);
Review Comment:
Question: Why not use `hasNonNull`? If anything I'd make a method for
getting null-able and non-null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
