jackye1995 commented on code in PR #4695:
URL: https://github.com/apache/iceberg/pull/4695#discussion_r938332793
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -401,6 +417,23 @@ public class AwsProperties implements Serializable {
*/
public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name";
+ /**
+ * Used by {@link LakeFormationAwsClientFactory}. The maximum size of the
lakeformation
+ * credentials cache, default to 100.
+ */
+ public static final String LAKE_FORMATION_MAX_CACHE_SIZE =
"lakeformation.max-cache-size";
+
+ public static final int LAKE_FORMATION_MAX_CACHE_SIZE_DEFAULT = 100;
+
+ /**
+ * Used by {@link LakeFormationAwsClientFactory}. The expiry time of the
cached lakeformation
+ * credentials in milliseconds, default to 30 minutes.
+ */
+ public static final String LAKE_FORMATION_CACHE_EXPIRY_MILLIS =
+ "lakeformation.cache-expiry-millis";
+
+ public static final long LAKE_FORMATION_CACHE_EXPIRY_MILLIS_DEFAULT = 30 *
60000;
Review Comment:
nit: 30 * 60 * 1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
