amogh-jahagirdar commented on code in PR #5379:
URL: https://github.com/apache/iceberg/pull/5379#discussion_r939222399
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:
##########
@@ -376,8 +376,8 @@ private void testDeleteFiles(int numObjects, S3FileIO
s3FileIO) throws Exception
List<String> paths = Lists.newArrayList();
for (int i = 1; i <= numObjects; i++) {
String deletionKey = objectKey + "-deletion-" + i;
- write(s3FileIO, String.format("s3://%s/%s", bucketName, deletionKey));
- paths.add(String.format("s3://%s/%s", bucketName, deletionKey));
+ write(s3FileIO, String.format("s3://%s/%s/%s", bucketName, prefix,
deletionKey));
+ paths.add(String.format("s3://%s/%s/%s", bucketName, prefix,
deletionKey));
Review Comment:
This integ test fix for guaranteeing cleanup at the end of the test class
execution, is related to this PR since it is testing the batch deletion path.
This is the same fix done in https://github.com/apache/iceberg/pull/5383 for
adding the test prefix in the path , so that we are always guaranteed at the
end of the test to cleanup these created objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
