rdblue commented on code in PR #5447:
URL: https://github.com/apache/iceberg/pull/5447#discussion_r939692650
##########
python/pyiceberg/catalog/hive.py:
##########
@@ -229,24 +290,43 @@ def create_table(
ValueError: If the identifier is invalid
"""
database_name, table_name =
self.identifier_to_database_and_table(identifier)
- current_time_millis = int(time.time())
+ seconds_since_epoch = int(time.time())
+
+ location = self._resolve_table_location(location, database_name,
table_name)
+
+ metadata_location = f"{location}metadata/{uuid.uuid4()}.metadata.json"
+ metadata = TableMetadataV2(
+ location=location,
+ schemas=[schema],
Review Comment:
The schema field IDs and partition field IDs need to be reassigned to ensure
that they are consistent because we don't trust that users pass them in
correctly. Passing them directly is okay for this PR, but we should not release
until we have reassignment done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
