nastra commented on code in PR #5407:
URL: https://github.com/apache/iceberg/pull/5407#discussion_r940060609
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -74,4 +74,8 @@ public String table(TableIdentifier ident) {
public String rename() {
return SLASH.join("v1", prefix, "tables", "rename");
}
+
+ public String scanReport() {
+ return SLASH.join("v1", prefix, "metrics", "scan");
Review Comment:
I did consider both approaches and was 50/50 on which to take and went with
the generic endpoint. Making this a table-specific path sgtm.
However, I would probably consider using
`v1/namespaces/{namespace}/tables/{table}/metrics/scan` as the path, since just
`metrics` sounds quite generic and doing a `GET` against `metrics` (if we would
ever support that) might return completely different metrics than scan metrics.
Also we would be future-proof in case we'd want to add some other non-scan
related metrics under `v1/namespaces/{namespace}/tables/{table}/metrics/xyz`.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
