Fokko commented on code in PR #5447:
URL: https://github.com/apache/iceberg/pull/5447#discussion_r940519064
##########
python/pyiceberg/catalog/hive.py:
##########
@@ -197,17 +234,41 @@ def __init__(self, name: str, properties: Properties,
uri: str):
super().__init__(name, properties)
self._client = _HiveClient(uri)
- def _convert_hive_into_iceberg(self, table: HiveTable) -> Table:
- # Requires reading the manifest, will implement this in another PR
- # Check the table type
- return Table(identifier=(table.dbName, table.tableName))
+ def _convert_hive_into_iceberg(self, table: HiveTable, metadata_location:
Optional[str] = None) -> Table:
+ properties: Dict[str, str] = table.parameters
+ if TABLE_TYPE not in properties or properties[TABLE_TYPE] != ICEBERG:
+ raise NoSuchTableError(f"Table is not an Iceberg table:
{table.dbName}.{table.tableName}")
+
+ if not metadata_location:
+ if prop_metadata_location := properties.get(METADATA_LOCATION):
+ metadata_location = prop_metadata_location
+ else:
+ raise NoSuchTableError("Metadata location not found")
+
+ file = PyArrowFile(metadata_location)
Review Comment:
I didn't want to spend too much time on it in this PR. I've created a stub
for it 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
