namrathamyske commented on code in PR #5364:
URL: https://github.com/apache/iceberg/pull/5364#discussion_r940694591
##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -61,6 +61,19 @@ public TableScan appendsAfter(long fromSnapshotId) {
return appendsBetween(fromSnapshotId, currentSnapshot.snapshotId());
}
+ @Override
+ public TableScan useBranch(String name) {
Review Comment:
@amogh-jahagirdar do theseneed to be implemented in BaseTableScan? Just
following acc to `asOfTime`
##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -61,6 +61,19 @@ public TableScan appendsAfter(long fromSnapshotId) {
return appendsBetween(fromSnapshotId, currentSnapshot.snapshotId());
}
+ @Override
+ public TableScan useBranch(String name) {
Review Comment:
@amogh-jahagirdar do these need to be implemented in BaseTableScan? Just
following acc to `asOfTime`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
