aokolnychyi commented on code in PR #5469:
URL: https://github.com/apache/iceberg/pull/5469#discussion_r941824314
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestExpireSnapshotsAction.java:
##########
@@ -1176,10 +1176,10 @@ public void testExpireAction() {
Assert.assertEquals("Should not delete any files", 0, deletedFiles.size());
- Assert.assertSame(
- "Multiple calls to expire should return the same deleted files",
- pendingDeletes,
- action.expire());
+ Assert.assertEquals(
Review Comment:
This no longer has to be the same reference. I reuse `QueryExecution` so we
keep the old behavior. I added a new test below. It would fail otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
