rdblue commented on code in PR #5490:
URL: https://github.com/apache/iceberg/pull/5490#discussion_r942662808
##########
python/pyiceberg/table/sorting.py:
##########
@@ -83,6 +89,9 @@ def set_null_order(cls, values: Dict[str, Any]) -> Dict[str,
Any]:
direction: SortDirection = Field()
null_order: NullOrder = Field(alias="null-order")
+ def __str__(self):
+ return f"{self.transform}({self.source_id}) {self.direction}
{self.null_order}"
Review Comment:
Missing `)`.
##########
python/pyiceberg/table/sorting.py:
##########
@@ -83,6 +89,9 @@ def set_null_order(cls, values: Dict[str, Any]) -> Dict[str,
Any]:
direction: SortDirection = Field()
null_order: NullOrder = Field(alias="null-order")
+ def __str__(self):
+ return f"{self.transform}({self.source_id}) {self.direction}
{self.null_order}"
Review Comment:
If `transform` is the identity transform, it should be omitted. Rather than
`identity(category) ASC NULLS_FIRST` it should be `category ASC NULLS_FIRST`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
