kbendick commented on PR #5496: URL: https://github.com/apache/iceberg/pull/5496#issuecomment-1212494603
> The validation seems redundant but I'd also play around with the method name. +1 to the name thing. I changed it to `truncateStringWithoutLengthValidation`, which is better but I don't really love that either. I'm open to suggestions if anybody has any. I would potentially change the name of the _original_ function to `truncateStringWithLengthValidation` and make this the new function definition for the shorter name, but that involves updating more calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
