stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r944071871


##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
 env.execute("Test Iceberg DataStream");
 ```
 
+## UPSERT mode
+
+Iceberg supports `UPSERT` based on the primary key when writing data into v2 
table format. 
+
+Enable the `UPSERT` mode on a table by adding the `write.upsert.enabled` 
configuration. All writing will be in `UPSERT` mode unless you overwrite it 
when building the writer:

Review Comment:
   > All writing will be in `UPSERT` mode unless you overwrite it when building 
the writer:
   
   This part is not completed. "building the writer" is not followed by 
example. I would actually suggest remove this part. Instead, you can follow up 
with the previous sentence as "Here is an example create table SQL statement 
with upsert table property". 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to