kbendick commented on code in PR #5513: URL: https://github.com/apache/iceberg/pull/5513#discussion_r944896127
########## spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestSparkBucketFunction.java: ########## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.sql; + +import java.nio.charset.StandardCharsets; +import org.apache.iceberg.AssertHelpers; +import org.apache.iceberg.relocated.com.google.common.io.BaseEncoding; +import org.apache.iceberg.spark.SparkTestBaseWithCatalog; +import org.apache.spark.sql.AnalysisException; +import org.assertj.core.api.Assertions; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +public class TestSparkBucketFunction extends SparkTestBaseWithCatalog { + public TestSparkBucketFunction() {} + + @Before + public void useCatalog() { + sql("USE %s", catalogName); + } + + @Test + public void testBucketIntegers() { + Assert.assertEquals( + "Byte type should bucket similarly to integer", + 3, + scalarSql("SELECT system.bucket(10, 8Y)")); + Assert.assertEquals( + "Short type should bucket similarly to integer", + 3, + scalarSql("SELECT system.bucket(10, 8S)")); + // Integers + Assert.assertEquals(3, scalarSql("SELECT system.bucket(10, 8)")); + Assert.assertEquals(79, scalarSql("SELECT system.bucket(100, 34)")); + Assert.assertNull(scalarSql("SELECT system.bucket(1, CAST(null AS INT))")); + } + + @Test + public void testBucketDates() { + Assert.assertEquals(3, scalarSql("SELECT system.bucket(10, date('1970-01-09'))")); + Assert.assertEquals(79, scalarSql("SELECT system.bucket(100, date('1970-02-04'))")); + Assert.assertNull(scalarSql("SELECT system.bucket(1, CAST(null AS DATE))")); + } + + @Test + public void testBucketLong() { + Assert.assertEquals(79, scalarSql("SELECT system.bucket(100, 34L)")); + Assert.assertEquals(76, scalarSql("SELECT system.bucket(100, 0L)")); + Assert.assertEquals(97, scalarSql("SELECT system.bucket(100, -34L)")); + Assert.assertEquals(0, scalarSql("SELECT system.bucket(2, -1L)")); + Assert.assertNull(scalarSql("SELECT system.bucket(2, CAST(null AS LONG))")); + } + + @Test + public void testBucketDecimal() { + Assert.assertEquals(56, scalarSql("SELECT system.bucket(64, CAST('12.34' as DECIMAL(9, 2)))")); + Assert.assertEquals(13, scalarSql("SELECT system.bucket(18, CAST('12.30' as DECIMAL(9, 2)))")); + Assert.assertEquals(2, scalarSql("SELECT system.bucket(16, CAST('12.999' as DECIMAL(9, 3)))")); + Assert.assertEquals(21, scalarSql("SELECT system.bucket(32, CAST('0.05' as DECIMAL(5, 2)))")); + Assert.assertEquals(85, scalarSql("SELECT system.bucket(128, CAST('0.05' as DECIMAL(9, 2)))")); + Assert.assertEquals(3, scalarSql("SELECT system.bucket(18, CAST('0.05' as DECIMAL(9, 2)))")); + + Assert.assertNull( + "Null input should return null", + scalarSql("SELECT system.bucket(2, CAST(null AS decimal))")); + } + + @Test + public void testBucketTimestamp() { + Assert.assertEquals( + 99, scalarSql("SELECT system.bucket(100, TIMESTAMP '1997-01-01 00:00:00 UTC+00:00')")); Review Comment: Updated this timestamp literal to include timezone so that the test isn't flakey. We might want to set the default timezone in the base test class, but that could upset other tests. I'll investigate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
