zhaomin1423 commented on PR #5346: URL: https://github.com/apache/iceberg/pull/5346#issuecomment-1213625542
> @zhaomin1423 yea its a good question, it seems it was done this way in the initial split of the Spark modules to different versions. I think most of the spark code is actually the same across versions :(. I guess the other option is to have just one spark module and have a shim layer to take care of different things, but not sure that's easy either. Keeping a shim layer is difficult with the addition of versions，because a lot of reflect will be added, it is obscure when reading, and some question can't be found in compile stage. Adding a spark common module to put same code, it might be more easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
