rdblue commented on code in PR #5506:
URL: https://github.com/apache/iceberg/pull/5506#discussion_r945321558
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopMetricsContext.java:
##########
@@ -111,6 +113,56 @@ public void increment(Integer amount) {
};
}
+ /**
+ * The Hadoop implementation delegates to the FileSystem.Statistics
implementation and therefore
+ * does not require support for operations like unit() as the counter values
are not directly
+ * consumed.
+ *
+ * @param name name of the metric
+ * @param unit ignored
+ * @return counter
+ */
+ @Override
+ public org.apache.iceberg.metrics.Counter counter(String name, Unit unit) {
Review Comment:
We need to deprecate the other counter methods in this class, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
