szlta commented on issue #5507: URL: https://github.com/apache/iceberg/issues/5507#issuecomment-1214966766
Thanks all for the feedback here. I think [as referenced] since `UpdateSnapshotReferenceOperation` is comitting empty operations in a similar way already, we should make `SetSnapshotOperation` behave the same way. I think the empty commit in such cases will not cause noticeable performance degradation, and other than that I don't see a good reason why to keep that early `return` statement. I've opened a PR to make it happen at: https://github.com/apache/iceberg/pull/5536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
