kbendick commented on PR #5541: URL: https://github.com/apache/iceberg/pull/5541#issuecomment-1215704203
> thanks for the fix, I don't think we need to recursively cast, and after doing that we still need to do SuppressWarning. Given this is just a test, I think we can just add `SuppressWarning` to the test? Agreed. Since this is just test code, the potentially unsafe cast isn't really a concern here and it would be cleaner to simply add the suppression at the test level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
