hililiwei commented on code in PR #5535:
URL: https://github.com/apache/iceberg/pull/5535#discussion_r946382983
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -73,6 +73,12 @@ statement
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
+ | ALTER TABLE multipartIdentifier CREATE BRANCH identifier (AS OF VERSION
snapshotId)? (WITH SNAPSHOT RETENTION (((numSnapshots SNAPSHOTS) |
(snapshotRetain snapshotRetainTimeUnit)) | (numSnapshots SNAPSHOTS
snapshotRetain snapshotRetainTimeUnit)))? (RETAIN snapshotRefRetain
snapshotRefRetainTimeUnit)? #createBranch
+ | ALTER TABLE multipartIdentifier REPLACE BRANCH identifier (AS OF VERSION
snapshotId)? (WITH SNAPSHOT RETENTION (((numSnapshots SNAPSHOTS) |
(snapshotRetain snapshotRetainTimeUnit)) | (numSnapshots SNAPSHOTS
snapshotRetain snapshotRetainTimeUnit)))? (RETAIN snapshotRefRetain
snapshotRefRetainTimeUnit)? #replaceBranch
Review Comment:
good. thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
