kbendick commented on code in PR #5533:
URL: https://github.com/apache/iceberg/pull/5533#discussion_r947035061
##########
core/src/main/java/org/apache/iceberg/IncrementalDataTableScan.java:
##########
@@ -130,15 +131,26 @@ private static List<Snapshot> snapshotsWithin(
if (snapshot.operation().equals(DataOperations.APPEND)) {
snapshots.add(snapshot);
} else if (snapshot.operation().equals(DataOperations.OVERWRITE)) {
- throw new UnsupportedOperationException(
- String.format(
- "Found %s operation, cannot support incremental data in
snapshots (%s, %s]",
- DataOperations.OVERWRITE, fromSnapshotId, toSnapshotId));
+ if (incrementalPullIgnoreOverwrite(table)) {
+ continue;
+ } else {
Review Comment:
Or it might help readability to put this into a method. But I think just
skipping the `else` block and then immediately throwing is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
